Skip to content

Update license paths - #1898

Merged
db39 merged 3 commits into
masterfrom
1897-update-license-links
Jul 22, 2025
Merged

Update license paths#1898
db39 merged 3 commits into
masterfrom
1897-update-license-links

Conversation

@db39

@db39 db39 commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Resolves #1897

This change updates the paths to the PyYaml and MarkupSafe Python dependency licenses.

Review on CodeApprove

@db39 db39 linked an issue Jul 21, 2025 that may be closed by this pull request
@db39
db39 marked this pull request as ready for review July 21, 2025 11:49
@db39

db39 commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

@jdeanwallace - When I run the E2E tests (Pro) against a live device, two license links are broken (markupsafe and pyyaml). This also appears to be the case when manually clicking the links.

It looks like the paths have changed (at least on my device):

./venv/lib/python3.9/site-packages/markupsafe-3.0.2.dist-info/licenses/LICENSE.txt with the new pattern: ./venv/lib/python3.*/site-packages/markupsafe-*.dist-info/licenses/LICENSE*

./venv/lib/python3.9/site-packages/pyyaml-6.0.2.dist-info/licenses/LICENSE with the new pattern: ./venv/lib/python3.*/site-packages/pyyaml-*.dist-info/licenses/LICENSE*

The new patterns match other patterns we use.

However, after updating the patterns here, the tests fail.

So I'm not sure what's going on?

@jdeanwallace

Copy link
Copy Markdown
Contributor

@db39 – Thanks for catching this. I think there are some inconsistencies in how the packages are built for different architectures. I've tracked the issue here and pushed a workaround:

@db39

db39 commented Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

@jdeanwallace - Thanks! It's interesting that they're different based on the architecture. That workaround seems sensible, I'll get it merged.

@db39
db39 requested a review from jdeanwallace July 22, 2025 11:07

db39 commented Jul 22, 2025

Copy link
Copy Markdown
Contributor Author
Automated comment from CodeApprove ➜

@jdeanwallace please review this Pull Request

@jdeanwallace jdeanwallace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved


👀 @db39 it's your turn please take a look

@db39
db39 merged commit 29da3e7 into master Jul 22, 2025
14 checks passed
@db39
db39 deleted the 1897-update-license-links branch July 22, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update license links

2 participants